Fix typo in promtail ClusterRole #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pod` is not a valid resource in k8s, but `pods` is.
|
|
Codecov Report
@@ Coverage Diff @@
## master #2152 +/- ##
==========================================
- Coverage 61.50% 61.44% -0.06%
==========================================
Files 149 149
Lines 11935 11935
==========================================
- Hits 7341 7334 -7
- Misses 4012 4015 +3
- Partials 582 586 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podis not a valid resource in k8s, butpodsis.What this PR does / why we need it:
The existing ClusterRole won't work for pods, since
podis not a valid resource.podsis.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Checklist